Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] ignore terraform.d to avoid checking in plugins #205

Merged
merged 2 commits into from
Jan 24, 2019
Merged

[fix] ignore terraform.d to avoid checking in plugins #205

merged 2 commits into from
Jan 24, 2019

Conversation

ryanking
Copy link
Contributor

No description provided.

@ryanking ryanking requested a review from mbarrien January 24, 2019 17:54
@ryanking ryanking requested a review from a team as a code owner January 24, 2019 17:54
mbarrien
mbarrien suggested changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@mbarrien mbarrien left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will prevent checking in the terraform.d symlinks in each component, which are needed. Needs to be scoped to prevent checking in /terraform.d at the Git root level.

@codecov
Copy link

codecov bot commented Jan 24, 2019 •
edited
Loading

Codecov Report

Merging #205 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #205   +/-   ##
=======================================
  Coverage   57.99%   57.99%           
=======================================
  Files          11       11           
  Lines         807      807           
=======================================
  Hits          468      468           
  Misses        266      266           
  Partials       73       73

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dac8ea...30a3c86. Read the comment docs.

@ryanking
Copy link
Contributor Author

@mbarrien I pushed a change that should handle that.

@czimergebot czimergebot merged commit 3360137 into master Jan 24, 2019
@ryanking ryanking deleted the ryanking/ignore_terraform.d branch May 8, 2019 21:46
@vincenthsh vincenthsh mentioned this pull request Apr 24, 2024
Closed
@vincenthsh vincenthsh mentioned this pull request Nov 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edulop91 edulop91 edulop91 approved these changes

@mbarrien mbarrien mbarrien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryanking @mbarrien @edulop91 @czimergebot